Skip to content

Allow disabling cert-generator with a Helm value #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow disabling cert-generator with a Helm value #4186

wants to merge 1 commit into from

Conversation

@fabian4
Copy link
Contributor

@fabian4 fabian4 commented Oct 29, 2025

Proposed changes

Allow disabling cert-generator with a Helm value

Closes #4173

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Allow disabling cert-generator with a Helm value

@fabian4 fabian4 requested a review from a team as a code owner October 29, 2025 12:35
@nginx-bot
Copy link

nginx-bot bot commented Oct 29, 2025

Hi @fabian4!

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community label Oct 29, 2025
@github-actions github-actions bot added the helm-chart Relates to helm chart label Oct 29, 2025
@fabian4 fabian4 force-pushed the allow_disabling_cert_generator branch from a054b7b to 56a2aaf Compare October 29, 2025 12:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 29, 2025
sjberman
sjberman reviewed Oct 29, 2025
View reviewed changes
@fabian4 fabian4 force-pushed the allow_disabling_cert_generator branch from 56a2aaf to b199680 Compare October 30, 2025 14:28
@fabian4 fabian4 requested a review from sjberman October 30, 2025 14:30
sjberman
sjberman reviewed Oct 30, 2025
View reviewed changes
@fabian4
Allow disabling cert-generator with a Helm value
2776315 
Problem: Need to allow disabling cert-generator with a Helm value.

Solution: Allow disabling cert-generator with a Helm value.

Testing: Allow disabling cert-generator with a Helm value.
@fabian4 fabian4 force-pushed the allow_disabling_cert_generator branch from b199680 to 2776315 Compare October 31, 2025 01:05
@fabian4 fabian4 requested a review from sjberman October 31, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjberman sjberman Awaiting requested review from sjberman

At least 2 approving reviews are required to merge this pull request.

Assignees

@bjee19 bjee19

Labels

community documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes

Projects

NGINX Gateway Fabric
Status: 🆕 New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow disabling cert-generator with a Helm value

3 participants

@fabian4 @sjberman @bjee19